chore: token-interface by SwenSchaeferjohann · Pull Request #2362 · Lightprotocol/light-protocol

SwenSchaeferjohann · 2026-03-25T21:36:28Z

No description provided.

coderabbitai · 2026-03-25T21:36:37Z

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (58)

.github/workflows/js-token-interface-v2.yml is excluded by none and included by none
.gitignore is excluded by none and included by none
js/justfile is excluded by none and included by none
js/token-interface/.prettierrc is excluded by none and included by none
js/token-interface/README.md is excluded by none and included by none
js/token-interface/eslint.config.cjs is excluded by none and included by none
js/token-interface/package.json is excluded by none and included by none
js/token-interface/rollup.config.js is excluded by none and included by none
js/token-interface/src/account.ts is excluded by none and included by none
js/token-interface/src/constants.ts is excluded by none and included by none
js/token-interface/src/errors.ts is excluded by none and included by none
js/token-interface/src/helpers.ts is excluded by none and included by none
js/token-interface/src/index.ts is excluded by none and included by none
js/token-interface/src/instructions/_plan.ts is excluded by none and included by none
js/token-interface/src/instructions/approve.ts is excluded by none and included by none
js/token-interface/src/instructions/ata.ts is excluded by none and included by none
js/token-interface/src/instructions/burn.ts is excluded by none and included by none
js/token-interface/src/instructions/freeze.ts is excluded by none and included by none
js/token-interface/src/instructions/index.ts is excluded by none and included by none
js/token-interface/src/instructions/layout/layout-mint-action.ts is excluded by none and included by none
js/token-interface/src/instructions/layout/layout-mint.ts is excluded by none and included by none
js/token-interface/src/instructions/layout/layout-transfer2.ts is excluded by none and included by none
js/token-interface/src/instructions/layout/layout.ts is excluded by none and included by none
js/token-interface/src/instructions/load.ts is excluded by none and included by none
js/token-interface/src/instructions/load/decompress.ts is excluded by none and included by none
js/token-interface/src/instructions/load/select-primary-cold-account.ts is excluded by none and included by none
js/token-interface/src/instructions/revoke.ts is excluded by none and included by none
js/token-interface/src/instructions/thaw.ts is excluded by none and included by none
js/token-interface/src/instructions/transfer.ts is excluded by none and included by none
js/token-interface/src/instructions/unwrap.ts is excluded by none and included by none
js/token-interface/src/instructions/wrap.ts is excluded by none and included by none
js/token-interface/src/kit/index.ts is excluded by none and included by none
js/token-interface/src/load-options.ts is excluded by none and included by none
js/token-interface/src/read/associated-token-address.ts is excluded by none and included by none
js/token-interface/src/read/ata-utils.ts is excluded by none and included by none
js/token-interface/src/read/get-account.ts is excluded by none and included by none
js/token-interface/src/read/get-mint.ts is excluded by none and included by none
js/token-interface/src/read/index.ts is excluded by none and included by none
js/token-interface/src/spl-interface.ts is excluded by none and included by none
js/token-interface/src/types.ts is excluded by none and included by none
js/token-interface/tests/e2e/approve-revoke.test.ts is excluded by none and included by none
js/token-interface/tests/e2e/ata-read.test.ts is excluded by none and included by none
js/token-interface/tests/e2e/burn.test.ts is excluded by none and included by none
js/token-interface/tests/e2e/freeze-thaw.test.ts is excluded by none and included by none
js/token-interface/tests/e2e/helpers.ts is excluded by none and included by none
js/token-interface/tests/e2e/load.test.ts is excluded by none and included by none
js/token-interface/tests/e2e/transfer.test.ts is excluded by none and included by none
js/token-interface/tests/unit/account.test.ts is excluded by none and included by none
js/token-interface/tests/unit/instruction-builders.test.ts is excluded by none and included by none
js/token-interface/tests/unit/kit.test.ts is excluded by none and included by none
js/token-interface/tests/unit/public-api.test.ts is excluded by none and included by none
js/token-interface/tsconfig.json is excluded by none and included by none
js/token-interface/tsconfig.test.json is excluded by none and included by none
js/token-interface/vitest.config.ts is excluded by none and included by none
pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml and included by none
pnpm-workspace.yaml is excluded by none and included by none
scripts/format.sh is excluded by none and included by none
scripts/lint.sh is excluded by none and included by none

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: fd2d15d8-ec58-4ad4-bca0-ed646ad6f437

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch swen/single-ix

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

…aming

ananas-block · 2026-03-28T16:58:10Z

nit: duplicated toBigIntAmount helper

toBigIntAmount(amount: number | bigint): bigint is identically defined in three files:

js/token-interface/src/instructions/transfer.ts:26
js/token-interface/src/instructions/approve.ts:14
js/token-interface/src/instructions/burn.ts:16

Extract to a shared utility.

ananas-block · 2026-03-28T16:58:12Z

nit: inconsistent discriminator type declarations

Some discriminators are number constants written via writeUInt8(), others are Buffer used directly as instruction data:

// number (transfer.ts, approve.ts, burn.ts)
const LIGHT_TOKEN_TRANSFER_CHECKED_DISCRIMINATOR = 12;
const LIGHT_TOKEN_APPROVE_DISCRIMINATOR = 4;

// Buffer (freeze.ts, thaw.ts)
const LIGHT_TOKEN_FREEZE_ACCOUNT_DISCRIMINATOR = Buffer.from([10]);
const LIGHT_TOKEN_THAW_ACCOUNT_DISCRIMINATOR = Buffer.from([11]);

Pick one convention.

ananas-block · 2026-03-28T16:58:13Z

nit: buffer over-allocation in ATA encoding

js/token-interface/src/instructions/ata.ts:119:

const buffer = Buffer.alloc(2000);

The Borsh-encoded CompressibleConfig is ~50 bytes. 2000 is 40x what's needed.

.github/workflows/js-token-interface-v2.yml

Replace @lightprotocol/compressed-token/unified with the new @lightprotocol/token-interface package (pending publish of Lightprotocol/light-protocol#2362). - Use createTransferInstructions (object params, flat array return) - Use getAta for aggregated balance check - Use toKitInstructions from /kit export for native v2 conversion - Delete convertV1InstructionToV2 from utils.ts (replaced by /kit) - Remove pre-transaction batch splitting (SDK handles inline) - Fix spec fee payer terminology

init

3883e4e

SwenSchaeferjohann added 5 commits March 26, 2026 16:15

cleanup

a0a9489

refactor(token-interface): unify instruction APIs and SPL interface n…

e2204e0

…aming

simplify load

f2e01c2

reduce async

b6ce011

rm redundant rpc

149d806

SwenSchaeferjohann marked this pull request as ready for review March 28, 2026 14:48

add tests

2855847

SwenSchaeferjohann added 2 commits March 28, 2026 20:27

dedupe amount helper, unify ix disc

22cdd49

upd ci

7f8c061

SwenSchaeferjohann requested review from ananas-block and sergeytimoshin as code owners March 28, 2026 20:50

github-advanced-security bot found potential problems Mar 28, 2026

View reviewed changes

.github/workflows/js-token-interface-v2.yml Fixed Show fixed Hide fixed

SwenSchaeferjohann added 13 commits March 28, 2026 22:31

add perms

43009a9

more robust getsplinterface

0bd3fcc

rm close acc for transfer

46ee479

upd typed err in splinterface

822c2a1

add test cov for nowrap

df81770

add test cov for race condition on transfer

1671d05

dedup rpc calls between load and transfer

e0354c8

strict condition for spl interface fetch

6b7f932

concurrently fetch getMintDecimals and getSplInterfaces

283464e

build -> transfer

92fd88b

payer optional for all ixns + test cov

6a3bc05

stricter typing

c16c59b

refactor load

5741b28

format

963ac04

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: token-interface#2362

chore: token-interface#2362
SwenSchaeferjohann wants to merge 23 commits intomainfrom
swen/single-ix

SwenSchaeferjohann commented Mar 25, 2026

Uh oh!

coderabbitai bot commented Mar 25, 2026 •

edited

Loading

Review skipped

Uh oh!

ananas-block commented Mar 28, 2026

Uh oh!

ananas-block commented Mar 28, 2026

Uh oh!

ananas-block commented Mar 28, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

SwenSchaeferjohann commented Mar 25, 2026

Uh oh!

coderabbitai bot commented Mar 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Uh oh!

ananas-block commented Mar 28, 2026

Uh oh!

ananas-block commented Mar 28, 2026

Uh oh!

ananas-block commented Mar 28, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

coderabbitai bot commented Mar 25, 2026 •

edited

Loading